Trezor modals improvements #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
reviewed
Nov 18, 2020
guilhermemntt
force-pushed
the
trezorModals
branch
from
cac5438
to
42514d4
Compare
|
Thanks @matheusd for the review. PIN_LABELS has been removed and the input disabled. |
JoeGruffins
approved these changes
Nov 20, 2020
guilhermemntt
force-pushed
the
trezorModals
branch
from
1b8fb24
to
f54ea0b
Compare
|
Needs a rebase then should be able to merge |
guilhermemntt
force-pushed
the
trezorModals
branch
from
f54ea0b
to
9e3f2e0
Compare
|
Rebased. |
|
Apologies, another rebase now. |
17 tasks
amass01
approved these changes
Feb 27, 2021
|
|
||
| let Component = null; | ||
|
|
||
| if (waitingForPin) { |
There was a problem hiding this comment.
you could use useMemo to memorize the Component value.
|
|
||
| const trezorLabel = device ? deviceLabel : ""; | ||
|
|
||
| const className = classNames( |
guilhermemntt
force-pushed
the
trezorModals
branch
from
9e3f2e0
to
3e38f0c
Compare
|
Rebased. |
Create useTrezor custom hook
guilhermemntt
force-pushed
the
trezorModals
branch
from
e51a9e6
to
182090b
Compare
alexlyp
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes several implementation details among Trezor related components:
Refactor Trezor modals, finishing Modal components refactoring #2515 according to [discussion] Functional components & hooks #2438 and [discussion] CSS modules #2439.
Improve Trezor modals, removes misalignments and
CSSbugs, centralize PIN panel and change cancel and blue button position to right insted of left, similar to all other modals.Standardize all modals position according to:
margin-right: 296px;margin-bottom: 100px;margin-bottom: 100px;This approach centralizes all modals horizontally and vertically (nearly, since most SO's have top bars in their windows), in addition to avoid unconformities between modals ans specific
CSSrules.This change also removes the necessity of setting
position: fixed;,top: 0;,bottom: 0;,left: 0;,right: 0;andmargin: auto;in modals, taking advantage of the already set combination ofdisplay: flex;,align-items: center;andjustify-content: center;rules in overlay classes instead, much more reliable and modern.Prepare for the implementation of a new modal to solve Trezor firmware update progress bar #2955.
Rename Trezor constants to CONSTANT_CASE.
Closes Misalignment in Trezor modals #2897, closes Trezor: Letters in Pin entry are odd #2562 and closes [1.4.0-rc] Mismatched PIN input for trezor/decrediton. #1932.
All changes have been tested with Trezor model One emulator and latest master.