-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI dark color scheme implementation #2163
Conversation
Thanks for this PR. Lint is failing:
|
Thanks! I try to figure it out why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. It looks pretty good overall.
I have just some small comments.
The text to connect to the daemon in advanced mode still black
I do not like the icon's hover on the sidebar, because they barely can be seen. But this needed to be discussed with the design guys, not about this PR.
I like icons being variables now, they are more centralized, so it will be easier to find them.
Thanks for the comments. @linnutee, please review this change or any other implementation issue in this PR. I did not like the icon's hover on the sidebar neither, but they are animated icons. If it will be re-rendered, I am willing to fix it. @kyleFirethought, could you help me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to iterate on the dark theme, but indeed seems like an improvement.
This PR implements
Dark Mode: Master Issue
(#2089)Sub issues:
- Dark Mode: Navigation (#2090)
- Dark Mode: General layout (#2091)
- Dark Mode: Send view (#2092)
- UI dark color scheme. In-app views (#2122)
- UI dark color scheme. Launcher views (#2123)