Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI dark color scheme implementation #2163

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Jul 26, 2019

This PR implements Dark Mode: Master Issue (#2089)
Sub issues:
- Dark Mode: Navigation (#2090)
- Dark Mode: General layout (#2091)
- Dark Mode: Send view (#2092)
- UI dark color scheme. In-app views (#2122)
- UI dark color scheme. Launcher views (#2123)

@vctt94
Copy link
Member

vctt94 commented Jul 26, 2019

Thanks for this PR.

Lint is failing:

ERROR in ./app/style/Themes.less (./node_modules/css-loader??ref--8-1!./node_modules/less-loader/dist/cjs.js??ref--8-2!./app/style/Themes.less)
    Module not found: Error: Can't resolve '../style/icons/sortByDark.svg' in '/home/travis/build/decred/decrediton/app/style'
     @ ./app/style/Themes.less (./node_modules/css-loader??ref--8-1!./node_modules/less-loader/dist/cjs.js??ref--8-2!./app/style/Themes.less) 7:11003-11043
Child mini-css-extract-plugin node_modules/css-loader/index.js??ref--8-1!node_modules/less-loader/dist/cjs.js??ref--8-2!app/style/Tooltip.less:

@bgptr
Copy link
Collaborator Author

bgptr commented Jul 26, 2019

Thanks! I try to figure it out why

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. It looks pretty good overall.

I have just some small comments.

The text to connect to the daemon in advanced mode still black

image

I do not like the icon's hover on the sidebar, because they barely can be seen. But this needed to be discussed with the design guys, not about this PR.

hover example:
image

I like icons being variables now, they are more centralized, so it will be easier to find them.

@bgptr
Copy link
Collaborator Author

bgptr commented Aug 6, 2019

Thanks for the comments.
For the first issue, I could not find any guidance in the design spec, but I did something now:

Screenshot 2019-08-06 at 11 57 00

@linnutee, please review this change or any other implementation issue in this PR.

I did not like the icon's hover on the sidebar neither, but they are animated icons. If it will be re-rendered, I am willing to fix it. @kyleFirethought, could you help me?

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to iterate on the dark theme, but indeed seems like an improvement.

@alexlyp alexlyp merged commit bd63dd9 into decred:master Aug 8, 2019
@bgptr bgptr deleted the dark_theme branch August 9, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants