Fix negative locked #1839
Merged
Fix negative locked #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure moving the internal methods out of the balance calc stats is so important, but if you feel strongly enough about it, then sure. You might wanna test/check with decred/dcrwallet#1330 given that it modifies how the lockedByTickets/total balances work (do notice that PR performs a database migration on the wallet, so you might wanna backup your wallet dirs first). |
|
I think this way was easier because I can use the same methods on the backwards and the forward logic. If you have suggestions on ways to make the code cleaner, they can be helpful, as well. I will test with this PR, thanks for informing. |
vctt94
force-pushed
the
fixNegativeLocked
branch
5 times, most recently
from
77d54db
to
6d9eac9
Compare
matheusd
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
Working fine. All tests were with decred/dcrwallet#1330 applied.
vctt94
force-pushed
the
fixNegativeLocked
branch
from
6d9eac9
to
9e8aa28
Compare
alexlyp
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1823 .
It also clean up a bit the
StatisticsActions.I am starting the clean up by separating the methods from
balancesStats, making them more independent, and separating the backwards logic from the straight forward one.The objective behind that is to make it easier to understand and maintain the statistics logic.
This still a WIP because I still have to check if all the exports methods are right, and there are some more clean up to do, but I am opening this PR now so you guys can see it.
The immature and locked values on daily balance looks wrong on master and this PR also fixes it