Show vspd instances on /vsp page #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We previously had a hard-coded list of VSPs which should have been displayed when JavaScript was disabled, but that functionality was broken. I have removed it rather than fixing it. We should not be maintaining a list of vetted VSPs in two different places which can (and will) easily fall out of sync. - JavaScript warning is now styled in orange and bold so it stands out against normal paragraph text. - JavaScript which loads the stakepool table is now in a self-contained file.
- The intention was for the table to be sorted by Proportion but it was actually being sorted on Immature tickets.
- Provide some explanation for revoked tickets. - Hide legacy VSPs in a collapsible panel. - Fix bug where sort icons were positioned under column titles rather than beside.
dajohi
approved these changes
Mar 1, 2021
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview at https://dcrweb.jamieholdstock.com/vsp/
Lots of changes here, all justified and explained in commit comments. In summary, vspd instances are now displayed on the /vsp page, legacy VSPs are hidden in an expandable panel.
Closes #920
Related decred/vspd#231