Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cryptopower to /wallets #1144

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

dreacot
Copy link
Contributor

@dreacot dreacot commented Oct 4, 2023

@xaur
Copy link
Contributor

xaur commented Oct 5, 2023

Missing . at the end of the text label.

Similar to #1141 I suggest to change the first link like: Download and release notes to better communicate what is behind the link. "GitHub" is alien and confusing for end users looking to download the app.

Some ideas for the second link:

@dajohi
Copy link
Member

dajohi commented Oct 5, 2023

needs rebase

@dreacot
Copy link
Contributor Author

dreacot commented Oct 5, 2023

@dajohi rebased✅

@xaur changes effected

Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but needs another rebase.

@dreacot
Copy link
Contributor Author

dreacot commented Oct 13, 2023

@jholdstock rebased

@jholdstock jholdstock merged commit ed7f23d into decred:master Oct 13, 2023
2 checks passed
@dreacot dreacot deleted the add_cryptopower branch October 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cryptopower to /wallets
4 participants