Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exchanges.yml #1139

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Update exchanges.yml #1139

merged 2 commits into from
Sep 9, 2023

Conversation

Clopas
Copy link
Contributor

@Clopas Clopas commented Sep 8, 2023 •
edited
Loading

closes #1134
closes #1133
closes #1087

@Clopas
Update exchages.yml
4640753 
*Add Kucoin and Huobi
*Remove Hotbit
*Add 4 other exchanges
@Clopas
Copy link
Contributor Author

Clopas commented Sep 8, 2023

I also added 4 new exchanges: Bitbns, Bingx, Coinex, Mexc
The criteria to add are as below.
They should comply with all three of the following:

  1. In the top 20 in terms of the reported DCR 24-hour trading volume. (source: coinmarketcap)
  2. In the top 20 in terms of the liquidity score. (source: coinmarketcap)
  3. Has a chart in Tradingview

jholdstock
jholdstock requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the important criteria is that a DCR community member must have used the exchange to validate that withdrawals and deposits are actually possible.

I suggest removing the 4 new exchanges from this PR and adding them in a new one, that way the additions can be discussed/reviewed/merged separately.

@Clopas Clopas changed the title Update exchages.yml Update exchanges.yml Sep 8, 2023
@Clopas
Update exchanges.yml
2b5bda6 
*Remove 4 new exchanges to open a seperate PR for them.
@Clopas
Copy link
Contributor Author

Clopas commented Sep 8, 2023 •
edited
Loading

Thank you for the review. I didn't realise that before. I removed the new ones and will open a separate PR for the new exchanges to discuss, etc.

@xaur
Copy link
Contributor

xaur commented Sep 8, 2023

Yeah we don't want to send people to exchanges with deposit or withdrawal issues from https://decred.org/exchanges/ . Unfortunately they happen. I believe in this case the friction to add new items is justified.

@jholdstock jholdstock merged commit 0f7bf14 into decred:master Sep 9, 2023
2 checks passed
@jholdstock
Copy link
Member

Thanks @Clopas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholdstock jholdstock jholdstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Huobi back Remove Hotbit Kucoin now accepting DCR deposits again. Should be added to Exchanges
3 participants
@Clopas @xaur @jholdstock