Move initial rescan to global syncer loop #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the Blocks backend function wait until the backend has peers instead of returning with ErrNoPeers. This makes this function safe to be used in the face of flaky connection to peers.
This is more reliable as it ensures the function is blocked until either a peer is connected or the context closes without a busy wait.
This moves the initial account and address discovery and rescan from the per-peer startup procedure to the global syncer startup sync procedure. This makes the code easier to reason about and removes the need for the atomic lock to the discoverAccounts field. The previous code would execute a rescan after every connected peer, if it had any new headers that connected to the main chain. With the changes in this commit, the syncer now only performs the full rescan once at startup and relies on the header announcement logic to scan when new blocks are relayed from peers after the initial sync.
This is not used anywhere.
jrick
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the initial account and address discovery and rescan from the per-peer startup procedure to the global syncer startup sync procedure.
This makes the code easier to reason about and removes the need for the atomic lock to the discoverAccounts field.
The previous code would execute a rescan after every connected peer, if it had any new headers that connected to the main chain. With the changes in this commit, the syncer now only performs the full rescan once at startup and relies on the header announcement logic to scan when new blocks are relayed from peers after the initial sync.
It also finishes switching all backend functions in SPV to use
waitForRemotesand removes unneeded functions.Part of #2289