Protect passphrase MAC hasher with mutex #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the hasher mutates its state, but it was being used by the UnlockedWithPassphrase method with the manager's read mutex held. This adds an additional mutex for protecting just the hasher. This fixes a data race caused when concurrently unlocking the wallet from several goroutines, and the invalid passphrase errors that were caused by racing on the hasher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the hasher mutates its state, but it was being used by the
UnlockedWithPassphrase method with the manager's read mutex held.
This adds an additional mutex for protecting just the hasher.
This fixes a data race caused when concurrently unlocking the wallet
from several goroutines, and the invalid passphrase errors that were
caused by racing on the hasher.