Make passphrases optional in most gRPC methods #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the client is now authenticated using TLS client certificates, it is safe to allow gRPC methods to be called and use wallet private keys even if the request itself does not provide the private passphrase. For backwards compatibility, keep the existing behavior when a nonzero passphrase is provided, but do nothing to unlock the wallet or check the passphrase when it has zero length. In order for this to be useful, a future commit must add the ability to lock or unlock the wallet from separate methods. This functionality already exists for individually-encrypted accounts.
vctt94
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
LGTM, but decrediton still needs changes on its end for properly dealing with theses scenarios, otherwise we can end with stuck funds, for example, like @alexlyp noted when testing decred/decrediton#2664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the client is now authenticated using TLS client certificates,
it is safe to allow gRPC methods to be called and use wallet private
keys even if the request itself does not provide the private
passphrase. For backwards compatibility, keep the existing behavior
when a nonzero passphrase is provided, but do nothing to unlock the
wallet or check the passphrase when it has zero length.
In order for this to be useful, a future commit must add the ability
to lock or unlock the wallet from separate methods. This
functionality already exists for individually-encrypted accounts.