dcrdtest: Remove need for *testing.T #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for passing a valid *testing.T object to the harness initializing function New() by switching the logging statements from using the test object to log it to using a standard slog logger. The API is not yet changed to avoid having to perform a major version bump in the package, but a deprecation note is added to the function's documentation. The purpose of this change is to allow this package to be more broadly useful, not just in tests, but also in benchmarks and in generic code not tied specifically to tests.
davecgh
reviewed
Oct 18, 2023
| if err := h.node.shutdown(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if !(debug || trace) { |
There was a problem hiding this comment.
I wonder if this should be retained via another means?
There was a problem hiding this comment.
Good point. The way I've done it in dcrlnd is that on test failures, the data dirs (dcrd, dcrwallet, etc) are kept, while on test successes they are automatically removed. I could bring that same behavior here, or add a *Harness.KeepTestNodeDir() or something for doing it manually.
I'm working on an additional PR that improves setup/teardown reliability, so I could also add it as part of that.
davecgh
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for passing a valid *testing.T object to the harness initializing function New() by switching the logging statements from using the test object to log it to using a standard slog logger.
The API is not yet changed to avoid having to perform a major version bump in the package, but a deprecation note is added to the function's documentation.
The purpose of this change is to allow this package to be more broadly useful, not just in tests, but also in benchmarks and in generic code not tied specifically to tests.
Fixes #2