Use blockHash for AcceptedWorkID, not powHash. #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Oct 18, 2023
As of DCP-0011, dcrpool now has to deal with two types of hash - block hash and pow hash. To reduce the chance of confusion, this renames "hash" to "powHash" where appropriate.
blockHash is used to construct the AcceptedWorkID when retrieving AcceptedWork from the database, not the powHash. Because of this bug, dcrpool was failing to register when a block mined by the pool had been confirmed, thus it was never sending the coinbase from that block to the mining participants.
jholdstock
force-pushed
the
powhash-bug
branch
from
2633ccf
to
89c637f
Compare
|
Good update with the rename to |
davecgh
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockHash is used to construct the AcceptedWorkID when retrieving AcceptedWork from the database, not the powHash.
Because of this bug, dcrpool was failing to register when a block mined by the pool had been confirmed, thus it was never sending the coinbase from that block to the mining participants.