Revert bbolt database to version 1. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade added a new bucket "hashdatabkt" to the database. This bucket is already being created in InitBoltDB so no additional changes are necessary. On top of that, because BoltDBVersion was never updated to 7, this upgrade was never being run anyway.
This upgrade set the UUID field on every entry in the payments and archived payments buckets. I have confirmed that payments/archived payments are never persisted without their UUID set, so this upgrade is no longer necessary and no additional changes are required.
This upgrade set the CreatedOn field on every entry in the share bucket. I have confirmed that shares are never persisted without their CreatedOn set, so this upgrade is no longer necessary and no additional changes are required.
This upgrade removed the value "txfeereserve" from the pool bucket. I have confirmed this value is no longer being inserted to the database anywhere, so this upgrade is no longer necessary and no additional changes are required.
This upgrade changed the ID format and set the Source for every payment/archived payment. I have confirmed that the new ID format is already used everywhere, and the Source is always set before payments/archived payments are persisted, so this upgrade is no longer necessary and no additional changes are required.
This upgrade changed the ID format and removed the CreatedOn field from shares. The new key is already in use throughout the code, and the CreatedOn field was actually restored in an upgrade which came after this one, so no additional changes are required..
This upgrade set the TransactionID for every payment and archived payment. I have confirmed that TransactionID is always set before payments/archived payments are persisted, so this upgrade is no longer necessary and no additional changes are required.
davecgh
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all bbolt database upgrades and reverts the database version to 1. All associated tests and test databases are also removed. I have left the upgrade framework and the testing framework in place so as not to lose the baby with the bathwater.
To support this change, I'd like to propose we label the next dcrpool release 2.0.0.
I believe we should take the opportunity to do this because there are no known public deployments of dcrpool at the moment, this could be the last chance to wipe the slate clean in this way. I don't believe there are any drawbacks to this plan, but there are several notable benefits:
transactionIDUpgradeandpaymentSourceUpgradewere real examples of this kind of issue). Consistent data means a lot of potential bugs/support issues which could be avoided down the line.