main: Correct defer handling in main entrypoint. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the unused error return from the newConfigParser function and updates the callers accordingly.
jholdstock
approved these changes
Sep 12, 2023
This refactors the main code into a separate function that returns an error instead of invoking os.Exit directly to ensure that the defers that are setup prior to the exits are run as intended. The main func will now exit with the non-zero error code when an error is returned from the refactored separate func.
davecgh
force-pushed
the
main_no_os_exit_after_defer
branch
from
3e6ee25
to
7477414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #350.
This refactors the main code into a separate function that returns an error instead of invoking
os.Exitdirectly to ensure that the defers that are setup prior to the exits are run as intended.The
mainfunc will now exit with the non-zero error code when an error is returned from the refactored separate func.