multi: add payment request processing. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
payment_requests
branch
from
26d41dd
to
55f9922
Compare
jholdstock
reviewed
Nov 26, 2019
| maturePayments, err := FetchMaturePendingPayments(db, height) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| bundles := generatePaymentBundles(maturePayments) | ||
| for idx := 0; idx < len(bundles); idx++ { | ||
| for idx := len(bundles) - 1; idx >= 0; idx-- { |
There was a problem hiding this comment.
Is there a reason this is iterating backwards? Might be nice to explain this unusual loop with a comment
There was a problem hiding this comment.
Yeah, iterating backwards is convenient here because the slice gets updated (via deletion) during iteration. When that happens the current index decrements (i--), iterating backwards already takes care of the decrement if there should be a deletion. It's ideal as result.
There was a problem hiding this comment.
Clever. Definitely worth a comment to ensure people don't try and change this in future
This implements payment processing infrastructure to the pool and fixes an off-by-one bug regarding pruning eligible payments based on the minimum allowed amount.
dnldd
force-pushed
the
payment_requests
branch
from
55f9922
to
abd2ed7
Compare
jholdstock
approved these changes
Nov 26, 2019
dajohi
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements payment processing infrastructure to the pool and fixes an off-by-one bug regarding pruning eligible payments based on the minimum allowed amount.