Updating BLAKE-256 page #1034
Updating BLAKE-256 page #1034
Conversation
|
@zubairzia0 please rebase over master |
Very detailed review and I agree with the changes requested, thank you @jholdstock. I believe I got everything requested. |
There was a problem hiding this comment.
A couple of extra things noticed.
I believe @davecgh said he would give this a once over as well, so it would be great to get an approval from him before this is merged.
|
|
||
| A more detailed description of the compression function can be found in [SHA-3 proposal BLAKE](https://decred.org/research/aumasson2010.pdf). | ||
|
|
||
| #### ChaCha inspired core function |
There was a problem hiding this comment.
Honestly, I see no benefit to including this in the documentation. It is all well documented by the authors of the hash function themselves in the standard that describes it.
I feel like the purpose of this documentation should be to describe the core concepts involved in informing the decision to use the hash function.
That means the sections on HAIFA vs M-D, security evaluation criteria, security bounds, and software and hardware performance all make sense, but just regurgitating the specification does not, imo.
There was a problem hiding this comment.
Agreed, I have taken out those sections. How does it look now?
|
Looking good to me, just need to remove all of the inline html super/sub-scripting |
BLAKE-256 page updates. The update is based on various academic sources as well as on NIST reports. I have created some illustrations in SVG to explain some concepts, as well.
closes #947