Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump x/crypto for blake2 .s stack corruption fixes #982

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Bump x/crypto for blake2 .s stack corruption fixes #982

merged 1 commit into from
Feb 21, 2021

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Feb 21, 2021

No description provided.

chappjc
chappjc approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

We should consider this a reason to switch to a hash function in Go's core library (no need to update our dependencies, just rebuild), such as crypto/sha256.

@chappjc chappjc merged commit 51f0c57 into decred:master Feb 21, 2021
@chappjc chappjc mentioned this pull request Feb 21, 2021
Merged
@dajohi dajohi deleted the smash branch June 21, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chappjc chappjc chappjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dajohi @chappjc