Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample config files #927

Merged
merged 7 commits into from
Jan 22, 2021
Merged

sample config files #927

merged 7 commits into from
Jan 22, 2021

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Jan 15, 2021

Closes #844

@amass01 amass01 marked this pull request as ready for review January 16, 2021 01:47
chappjc
chappjc reviewed Jan 18, 2021
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Mostly minor revisions, but a little text near the top of the samples to describe some of the switches like version and listcommands that don't make sense in a config file.

client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
client/cmd/dexcctl/sample-dexcctl.conf Outdated Show resolved Hide resolved
client/cmd/dexcctl/sample-dexcctl.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Show resolved Hide resolved
@amass01
Copy link
Member Author

amass01 commented Jan 18, 2021

@chappjc Thanks for the review, updated

JoeGruffins
JoeGruffins reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Srry for "Default is false." so many times. Can ignore if you want, but I think would be good to put. Also, in some of the cases where the default is false, the value is true, but others is false. I think those should all be true, because the user would uncomment-out to turn on.

client/cmd/dexcctl/sample-dexcctl.conf Outdated Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
client/cmd/dexc/sample-dexc.conf Outdated Show resolved Hide resolved
server/cmd/dcrdex/sample-dcrdex.conf Outdated Show resolved Hide resolved
@amass01
Copy link
Member Author

amass01 commented Jan 20, 2021

@buck54321 @JoeGruffins updated mates 👍

@chappjc chappjc merged commit 792602b into decred:master Jan 22, 2021
@amass01 amass01 deleted the sampleconfigs branch January 28, 2021 12:01
@chappjc chappjc added this to the 0.2 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 left review comments

@chappjc chappjc chappjc approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

sample config files
4 participants
@amass01 @buck54321 @chappjc @JoeGruffins