multi: switch to coin id #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
requested changes
Dec 2, 2019
This commit and other changes in this PR change the way fees are evaluated on the server. It was meant to be a couple of small changes as I reworked the DEXAsset interface, but it became a whole thing. In particular, the BTC and clone backends use vsize for fee evaluation instead of byte size, and the DCR backends evaluate the fees as zero for coinbase transactions. The second change does little for us in production, since we don't evaluate fees on funding transactions, but for live testing, it helps to tame some unwanted behavior.
chappjc
approved these changes
Dec 3, 2019
|
|
||
| // Convert the DCR value to atoms. | ||
| func toAtoms(v float64) uint64 { | ||
| return uint64(math.Round(v * 1e8)) |
There was a problem hiding this comment.
I'm always squeamish about multiplying in float, but this is what dcrutil.NewAmount does so I suppose it's sufficient for a *1e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the switch to coin ID proposed in #75. Coin IDs are used to identify spendable value, and are represented as a variable-length byte array (
[]bytein Go). Asset backends and wallets have some latitude to choose encoding, though for UTXO-based assets, the encoding<32-byte tx hash>|<4-byte vout>is recommended.