-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/{auth,db}: add order_status route #687
Conversation
Will get on this today 100%, just a little delayed with a different fix. I'm note sure we care too much about order_status and match_status being limited to the owning user though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, will return to this shortly. We may need to consider queries for cancel orders too. Alternatively, client could check the status of the targeted order instead and assume the cancel order that they are interested in was the one that matched it.
|
I think we can move forward without cancel order status support at least initially. Discussion in #687 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. If you weren't planning on following up immediately with a spec update, please open an issue.
Plan is to put that up after this gets merged, while #677 is reviewed. That way, I can include this new route and the update to the connect response. |
Similar in implementation to the match_status route, the order_status route accepts a slice of `struct{Base,Quote,OrderID}` and returns the status and fill amts for the requested **user-submitted** orders that are found in db. Will follow up with spec changes.
92db6eb
to
0012cf0
Compare
0012cf0
to
6afd7bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I kinda question the need for a map in pg.orderStatuses
. Eager to get moving on including active orders in the 'connect'
map, and that work will provide opportunity to tweak this work.
Similar in implementation to the match_status route, the order_status route
accepts a slice of
struct{Base,Quote,OrderID}
and returns the status andfill amts for the requested user-submitted orders that are found in db.
Will put up a follow up with spec changes for the new
order_status
routeand the updated
connect
route.