dex/testing/dcr: fix reorg script #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itswisdomagain
commented
Sep 7, 2020
JoeGruffins
reviewed
Sep 16, 2020
|
Yeah... Add a second wallet to beta that can vote on tickets purchased by the alpha wallet i.e. shares the same seed with the alpha wallet. Gave that a rough trial but didn't work as expected. Will get back to it once I have some time. |
|
Convert to draft? |
The dcr beta node is only able to add 1 block to the mainchain after disconnecting from the alpha node, because the beta node has no way to receive votes while disconnected from alpha. This prevents reorgs on either nodes since the reorg script ends with both nodes reconnected but having just 1 divergent mainchain block each. This is fixed by mining an "extra" block on either node (after reconnection) to trigger a reorg on the other node. Additionally, the dcr reorg script is modified to accept 2 optional arguments: `./reorg (node depth), where - `node` is the node that should experience a reorg, either "alpha" or "beta" - `depth` is the number of blocks that should be purged from `node`. Currently, due to the beta mining limitation mentioned above, only 1 block can be purged from either nodes during reorg, but the reorged node will always see `depth` new blocks after the reorg.
During reorg, a clone of the alpha wallet is connected to the beta node after the beta node is disconnected from the alpha node. The added wallet uses the same seed as the alpha wallet and is thus able to vote on tickets purchased by the alpha wallet when the alpha node was connected to the beta node. Without a voting wallet connected to the beta node, it can only mine 1 block after it is disconnected from the alpha node. Moreover, connecting just any voting wallet to the beta node does not suffice as the added wallet may not have enough tickets called to vote on a previous block because the tickets called to vote are selected from a pool of tickets purchased by both the new and the alpha voting wallets and the alpha voting wallet may have more tickets called to vote on the previous block than the other voting wallet connected to the beta node.
itswisdomagain
force-pushed
the
reorg-fixes
branch
from
12bf8be
to
fe438e9
Compare
JoeGruffins
approved these changes
Aug 12, 2021
chappjc
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dcr reorg script is modified to accept 2 optional arguments:
`./reorg (node depth), where
nodeis the node that should undergo a reorg, either "alpha" or "beta" (default: alpha)depthis the number of blocks that should be purged fromnode(default: 2).At the end of the reorg, both nodes will have
depth+1new blocks.During reorg, a clone of the alpha wallet is connected to the beta node after the beta node
is disconnected from the alpha node. This is done to enable mining multiple blocks on the
beta node.
The alpha wallet clone uses the same seed as the alpha wallet and is thus able to vote on
tickets purchased by the alpha wallet when the alpha node was connected to the beta node,
supplying enough votes to the beta node to validate previous blocks and allow the creation
of new blocks.
Resolves #646.