client/core: rate fetcher tweaks #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
commented
Sep 10, 2023
| defaultRequestTimeout = time.Second * 20 | ||
| defaultRequestTimeout = time.Second * 10 |
There was a problem hiding this comment.
I had set this to 20 seconds a while back, but I've come to realize that I had a misconfiguration on my system that brought some glibc bug to the surface that was causing hella long DNS lookup times in some cases.
martonp
approved these changes
Sep 12, 2023
client/core/exchangeratefetcher.go
Outdated
| } | ||
|
|
||
| reader := io.LimitReader(resp.Body, 1<<20) | ||
| return json.NewDecoder(reader).Decode(thing) | ||
| } | ||
|
|
||
| func tokenSymbol(symbol string) string { |
There was a problem hiding this comment.
This could go in bip-id.go. It'll probably be useful elsewhere.
| // month for the all tickers request, and 3600 * N requests for N assets. | ||
| // So any more than 25000 / 3600 = 6.9 assets, and we can expect to run into | ||
| // rate limits. But the bandwidth of the full tickers request is kinda | ||
| // ridiculous too. Solution needed. |
There was a problem hiding this comment.
Could keep track of how many requests are made, and if it gets to point where it can only make it through the rest of the month if only the all assets request is used, then switch to the all assets request. For most people it won't make it to that point because they don't keep dexc on all the time.
buck54321
force-pushed
the
fiat-fixes
branch
from
2f0c575
to
fd50c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run rate fetcher all the time, regardless of whether we have sources. If we don't have sources, its a no-op every 12 minutes which is not worth the complication involved with starting and stopping the fetch loop.
Use individual timeouts for requests, not a single timeout for all requests to complete.
Adds some documentation around request limits and our request rates.