server/eth: websocket header subscriptions and less frequent http polling #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
changed the title
JoeGruffins
approved these changes
Aug 31, 2023
buck54321
force-pushed
the
loopback-eth-block-interval
branch
from
a0b123c
to
d54fa8d
Compare
buck54321
force-pushed
the
loopback-eth-block-interval
branch
from
d54fa8d
to
e6e94b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't using header subscriptions with WebSocket provider connections, so were polling every second by default.
Add WebSocket header subscriptions to minimize requests.
Automatically increase the poll interval for HTTP connections if the IP is not a loopback address. Previously, the poll interval could be modified by setting the
blockPollIntervalStrwithldflagsat compile-time, but this is a little more user friendly, I think, and captures the intent just the same.