server/asset/firo: block parsing for median fees #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have asked @levonpetrosyan93 from 'firoorg' to comment |
Comment on lines
+292
to
+294
| // I have scanned the pre-ProgPOW sections of both testnet | ||
| // and mainnet and have yet to find non-zero HashRootMTP. I am | ||
| // speculating that the MTP proof data was purged in an upgrade |
There was a problem hiding this comment.
This is exactly correct. Later code purged unneeded MTP data.
JoeGruffins
approved these changes
Aug 31, 2023
server/asset/firo/firo.go
Outdated
| r := bytes.NewReader(b) | ||
| blk := NewFiroBlock(net) | ||
| if err := blk.readBlockHeader(r); err != nil { | ||
| return nil, fmt.Errorf("readBlocHeader error: %v", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("readBlocHeader error: %v", err) | |
| return nil, fmt.Errorf("readBlockHeader error: %v", err) |
server/asset/firo/firo.go
Outdated
| return nil, fmt.Errorf("ReadVarInt error: %v", err) | ||
| } | ||
| if _, err = io.CopyN(io.Discard, r, int64(sz)); err != nil { | ||
| return nil, fmt.Errorf("error discaring vExtraPayload: %v", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("error discaring vExtraPayload: %v", err) | |
| return nil, fmt.Errorf("error discarding vExtraPayload: %v", err) |
buck54321
force-pushed
the
firo-blocks
branch
from
6293047
to
a9582b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On testnet (v0.14.12.4), neither
estimatefeenorestimatesmartfeegive results, so we fall back to using median fees. Firo doesn't havegetblockstats, so we have to doManualMedianFeeand scan blocks, but we didn't have aBlockFeeTransactionsfunction set, so we were using the defaultwire.MsgBlock.Deserialize, which doesn't work for Firo. This made Firo unusable as a backend on testnet.This doesn't appear to be a problem on mainnet (v0.14.12.1) or simnet (v0.14.12.4). Note that v0.14.12.4 shouldn't be run on mainnet