Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: update deps #1996

Merged
merged 1 commit into from
Jan 5, 2023
Merged

site: update deps #1996

merged 1 commit into from
Jan 5, 2023

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Dec 15, 2022

 Patch Update Backwards-compatible bug fixes.
❯◉ bootstrap devDep   5.2.0  ❯  5.2.3  https://getbootstrap.com/
 ◉ css-loader devDep  6.7.1  ❯  6.7.3  https://github.com/webpack-contrib/css-loader
  
 Minor Update New backwards-compatible features.
 ◉ @babel/core devDep                       7.18.13  ❯  7.20.5   https://babel.dev/docs/en/next/babel-core
 ◉ @babel/plugin-transform-runtime devDep   7.18.10  ❯  7.19.6   https://babel.dev/docs/en/next/babel-plugin-transform-runtime
 ◉ @babel/preset-env devDep                 7.18.10  ❯  7.20.2   https://babel.dev/docs/en/next/babel-preset-env
 ◉ @babel/runtime devDep                    7.18.9   ❯  7.20.6   https://babel.dev/docs/en/next/babel-runtime
 ◉ @typescript-eslint/eslint-plugin devDep  5.35.1   ❯  5.46.1   https://github.com/typescript-eslint/typescript-eslint#readme
 ◉ @typescript-eslint/parser devDep         5.35.1   ❯  5.46.1   https://github.com/typescript-eslint/typescript-eslint#readme
 ◉ css-minimizer-webpack-plugin devDep      4.0.0    ❯  4.2.2    https://github.com/webpack-contrib/css-minimizer-webpack-plugin
 ◉ eslint devDep                            8.22.0   ❯  8.29.0   https://eslint.org
 ◉ eslint-plugin-promise devDep             6.0.1    ❯  6.1.1    https://github.com/eslint-community/eslint-plugin-promise
 ◉ mini-css-extract-plugin devDep           2.6.1    ❯  2.7.2    https://github.com/webpack-contrib/mini-css-extract-plugin
 ◉ sass devDep                              1.54.5   ❯  1.56.2   https://github.com/sass/dart-sass
 ◉ sass-loader devDep                       13.0.2   ❯  13.2.0   https://github.com/webpack-contrib/sass-loader
 ◉ stylelint devDep                         14.11.0  ❯  14.16.0  https://stylelint.io
 ◉ ts-loader devDep                         9.3.1    ❯  9.4.2    https://github.com/TypeStrong/ts-loader
 ◉ typescript devDep                        4.7.4    ❯  4.9.4    https://www.typescriptlang.org/
 ◉ webpack devDep                           5.74.0   ❯  5.75.0   https://github.com/webpack/webpack
 ◉ webpack-bundle-analyzer devDep           4.6.1    ❯  4.7.0    https://github.com/webpack-contrib/webpack-bundle-analyzer
  
 Major Update Potentially breaking API changes. Use caution.
 ◉ babel-loader devDep                    8.2.5   ❯  9.1.0   https://github.com/babel/babel-loader
 ◉ stylelint-config-standard devDep       28.0.0  ❯  29.0.0  https://github.com/stylelint/stylelint-config-standard#readme
 ◉ stylelint-config-standard-scss devDep  5.0.0   ❯  6.1.0   https://github.com/stylelint-scss/stylelint-config-standard-scss#readme
 ◉ webpack-cli devDep                     4.10.0  ❯  5.0.1   https://github.com/webpack/webpack-cli/tree/master/packages/webpack-cli
ncu --target latest -u
npm i
npm up   # for @types/latest and other transitive deps specified as "latest"

@chappjc chappjc added this to the 0.6 milestone Dec 29, 2022
@chappjc chappjc marked this pull request as ready for review December 29, 2022 01:29
@chappjc
Copy link
Member Author

chappjc commented Dec 29, 2022

No more major version bumps before 0.6 unless there's something critical.

@chappjc chappjc added the dependencies Pull requests that update a dependency file label Dec 29, 2022
@chappjc
Copy link
Member Author

chappjc commented Dec 29, 2022

Holding off on this until github/advisory-database#1541 is merged to fix the json5 "vuln" (it's not actually a vulnerability).

An npm up json5 to this will fix it once the CVE database is updated:

[email protected] .../client/webserver/site
├─┬ @babel/[email protected]
│ └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

@chappjc chappjc marked this pull request as draft December 29, 2022 15:20
This ensures the transitive json5 dep is updated to avoid the (bogus)
vulnerability report from npm audit.
@chappjc
Copy link
Member Author

chappjc commented Jan 4, 2023

The npm audit failure has vanished with json5 updated and github/advisory-database#1541 merged to reflect that 1.0.2 and 2.2.3 are OK. I have not tested the bundle output with this however. I need to focus on the bond rotation now, so will put this as ready for review if anyone has bandwidth to test the UI with these dep updates.

@chappjc chappjc marked this pull request as ready for review January 4, 2023 16:13
@chappjc chappjc linked an issue Jan 4, 2023 that may be closed by this pull request
Copy link
Contributor

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Chrome, Firefox, and Safari, and I see no issues.

@chappjc chappjc merged commit 1d26996 into decred:master Jan 5, 2023
@chappjc chappjc deleted the npm-up-all branch January 5, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client/site: Update linter when possible.
3 participants