client/dcr: Unlock wallet if acct not encrypted. #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Apr 12, 2022
Comment on lines
+699
to
+700
| if res.Encrypted { | ||
| return translateRPCCancelErr(w.rpcClient.UnlockAccount(ctx, acctName, string(pw))) |
There was a problem hiding this comment.
Thank you for restoring this logic. I suppose it makes sense to restore it down here in the rpcWallet code instead of up at the ExchangeWallet level where it was.
Also, I can confirm that (*rpcWallet).LockAccount does have this accountunlocked check.
client/core/core.go
Outdated
| @@ -1700,6 +1700,7 @@ func (c *Core) CreateWallet(appPW, walletPW []byte, form *WalletForm) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer crypter.Close() | |||
There was a problem hiding this comment.
Hmm, we don't do this anywhere, and there seem to be numerous places we should. Can we split this out and address them all in another PR?
There was a problem hiding this comment.
JoeGruffins
force-pushed
the
encryptacctthen
branch
from
4af6488
to
0fdbd4e
Compare
chappjc
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1576