client: sign and verify hashed messages (sig fix stage 2) #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2022
chappjc
force-pushed
the
sig-fix-stage-2
branch
from
ceab024
to
df80984
Compare
chappjc
force-pushed
the
sig-fix-stage-2
branch
from
df80984
to
9ea2001
Compare
|
0.4 based branch at https://github.com/chappjc/dcrdex/tree/sig-fix-stage-2-v0.4 |
JoeGruffins
approved these changes
Apr 18, 2022
client/asset/btc/btc.go
Outdated
| @@ -2184,12 +2184,13 @@ func (btc *baseWallet) SignMessage(coin asset.Coin, msg dex.Bytes) (pubkeys, sig | |||
| return nil, nil, err | |||
| } | |||
| pk := privKey.PubKey() | |||
| sig, err := privKey.Sign(msg) | |||
| hash := sha256.Sum256(msg) // legacy servers will not accept this signature! | |||
There was a problem hiding this comment.
btc test will use chainhash.HashB, just confirming you meant to use sha256.Sum256 It is the same though https://github.com/btcsuite/btcd/blob/bf64c8bdbbbfc6db51312769742e1210b8ac8ed0/chaincfg/chainhash/hashfuncs.go#L10-L14
This creates message signatures using a message hash (sha256) instead of the message itself, which was truncated. Verification of server signatures in incoming messages recognizes both signatures. When v0 is purged (V0PURGE), this should be removed. Also insert our pubkey back into register response.
Update Wallet.SignMessage impls to use an asset-specific hash function with the provided message. The resulting signatures will not be accepted by legacy servers.
chappjc
force-pushed
the
sig-fix-stage-2
branch
from
9ea2001
to
fb87ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #1528This is stage 2 of the signature message truncation fix plan outlined in #1526.
In these commits, client begins signing the hashed messages, but continues to recognize the buggy signatures from the server. This is because the while the server understands the correct hashed message signatures as of stage 1, it is still sending the old signatures with its messages.
This work can be backported to a 0.4.3+ release if #1528 has been deployed with 0.4.2.
In the next stage, the server begins sending the correct signatures.