client/{core,webserver}: show match revoked status #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supplement core.Match with an Active field, set via MatchIsActive. Update (*orderReader).hasLiveMatches to consult the Active field instead of just comparing Status < MakerRedeemed. Update (*matchReader).StatusString with text for revoked matches. When revoked and also active show "Revoked - Refund PENDING". When revoked and not active, show if it was refunded, (auto)redeemed, or simply complete when no txns are needed.
buck54321
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #922
Supplement
core.Matchwith anActivefield, set viadb.MatchIsActive.Update
(*orderReader).hasLiveMatchesto consult theActivefield instead of just comparingStatus < MakerRedeemed.Update
(*matchReader).StatusStringwith text for revoked matches.When revoked and also active show "Revoked - Refund PENDING".
When revoked and not active, show if it was refunded, (auto)redeemed, or simply complete when no txns are needed.
Revoked and waiting to refund
Revoked with nothing to do (inactive)
Revoked and auto-redeemed