multi: market overview and price feed #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
market-overview
branch
from
53cc9dc
to
d67c15e
Compare
chappjc
requested changes
Oct 15, 2021
buck54321
commented
Oct 15, 2021
| } | ||
| case 'spots': { | ||
| const xc = this.user.exchanges[note.host] | ||
| for (const [mktName, spot] of Object.entries(note.spots)) xc.markets[mktName].spot = spot |
There was a problem hiding this comment.
Another place this can come in handy is when showing lot sizes during registration. For display purposes only, especially if they are paying their fees in a market's quote asset, we could show them a conversion based on the current price without needing to subscribe to the market order book.
buck54321
commented
Oct 15, 2021
|
If anyone else looking at this on the simnet harness, I'll note that testing is a pain because we interpret our 24 hour change from the 5-minute candles, so even if you put some action on the books immediately, it can take 5 minutes before you see a non-zero change. |
chappjc
approved these changes
Oct 18, 2021
JoeGruffins
approved these changes
Oct 19, 2021
Fixed in #1238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #941
Add new
price_feedsubscription. The response to the subscription request contains the spot prices for all known markets. Subscribers will then receive an update to the spot price for every market at the end of every epoch.server/market
BookRouterhandles the subscriptions. The spot price is passed byMarketas part of thesigDataEpochReport. It was already being generated by(*DataAPI).ReportEpoch, but we were discarding it.dex/candles
(*Cache).Deltamethod updated to ignore leading and trailing zeros. Zeros occur when the book is empty.client/core
Subscribe to the price feed right after fetching configuration, including after reconnect. Populate the new
Market.Spotfield. Send updates as notifications.front-end
Display 24-hour percent change and current rate in the list on the left side of the markets view.