Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/db/bolt: omit copy of buffer and upgrade in separate db txns #1070

Merged
merged 1 commit into from
Apr 29, 2021

Commits on Apr 29, 2021

  1. client/db/bolt: omit copy of buffer used only in db txns

    try each upgrade in its own tx
    
    excludeCancels option for db.MatchesForOrder and reloadMatchProofs
    
    Cancel matches can be the lion's share of matches in some DBs, and in
    most cases it is not necessary to process these.
    - In db upgrades, there is no reason to reencode the MatchProof.
      Although it's not clear there is a reason to do this for trade matches
      either since any match proof version decodes automatically to the
      current MatchProof.
    - In (*Core).dbTrackers, cancel order matches are not used.
    - (*Core).coreOrderFromMetaOrder might be able to exclude cancel order
      matches, but the consumers are exported Core methods, so no change.
    
    This also include a prealloc optional arg to ExtractPushes and
    DecodeBlob, which is mainly helpful for the MatchProof buckets
    that have 22 pushes.
    
    do not set maxFeeRate for cancels v2 upgrade
    chappjc committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    bbd3bfd View commit details
    Browse the repository at this point in the history