client: application skeleton #100

buck54321 · 2019-12-10T14:51:54Z

This is a basic skeleton for a client app. It enables running an HTTP server or an RPC server. They both use the same client core, from the new core module. The default behavior is to run the servers from a simple but expandable TUI, but they can also be run without the TUI via command-line arguments or configuration file. Placeholder packages for the actual servers are in place, but don't do anything yet. A basic TUI infrastructure is built on tview, with enough code to demonstrate its use, but ultimately no functionality yet.

I'm hoping this provides a good framework on which concurrent development can proceed. I plan on getting into the web server this week, and maybe @JoeGruffins could continue fiddling with the TUI, or get into the RPC server. Once the web server is up, there will be front-end work to do there too. @dnldd can import and make use of the the order book code in the client core, and then expand from there.

JoeGruffins · 2019-12-11T08:31:13Z

Looks good to me!

chappjc · 2019-12-11T16:14:40Z

Good foundation for the client.
Looks like you'll want to rm the binary client/cmd/dexclient/dexclient

buck54321 · 2019-12-11T16:42:44Z

The dexclient binary actually snuck into master with some earlier client stuff. This PR removes it.

chappjc · 2019-12-11T16:55:03Z

Oh, whoops. I read the diff backwards.

JoeGruffins

Looks great. The left side for me, one character is cut off. I guess could use a way to resize... or the dots, like "Accounts & Wa..."

pic

Also, building with the --race flag and going to either web or rpc server and pressing enter twice finds two data races.

pic

And, the white text on a grey background is difficult for me to see everywhere...

client/cmd/dexc/main.go

client/cmd/dexc/ui/accountsview.go

JoeGruffins · 2020-01-08T02:41:16Z

client/cmd/dexc/ui/config.go

+		if _, ok := err.(*os.PathError); !ok {
+			fmt.Fprintln(os.Stderr, err)
+			parser.WriteHelp(os.Stderr)
+			return nil, err
+		}


Could use go's new error unwrapping here.
https://golang.org/pkg/errors/

if errors.Is(err, os.PathError) { fmt.Fprintln(os.Stderr, err) parser.WriteHelp(os.Stderr) return nil, err }

os.PathError is a type, not a sentinel, so I think you would need to use errors.As here, no?

@dajohi does this work?

Yeah, it would be As, but I'm comfortable with it the old way too.

client/cmd/dexc/ui/log.go

client/cmd/dexc/ui/marketview.go

client/cmd/dexc/ui/serverview.go

JoeGruffins · 2020-01-08T05:23:01Z

client/cmd/dexc/ui/widgets.go

+var welcomeMessage = "Welcome to Decred DEX. Use [#838ac7]Up[white] and " +
+	"[#838ac7]Down[white] arrows and then press [#838ac7]Enter[white] to select" +
+	" a new view. The [#838ac7]Escape[white] key will usually toggle the focus" +
+	" between the menu and the currently selected view. When the selected view" +
+	" is focused, most navigation can be done with your the [#838ac7]Left" +
+	"[white] and [#838ac7]Right[white] arrows, or alternatively [#838ac7]Tab" +
+	"[white] and [#838ac7]Shift+Tab[white]. Use [#838ac7]Escape[white] to remove" +
+	" focus from a form element."


The white on grey is hard for me to see...

White on grey? Do you mean the purple parts? The white text with default background is default console coloring, I think.

If you look at the first pic I uploaded you can see what I see by default.

Oh weird. I'll look into it.

dcrdex/client/cmd/dexc/ui/widgets.go

Line 473 in 47ece4c

tview.Styles.PrimitiveBackgroundColor = backgroundColor

See if that works for you when you get a chance.

Ok! so, running like so xterm ./dexc and I get a nice picture. Creating a new xterm window for the app has fixed the colors for me.

pic

What interesting is that the inline-colored (1) next to Notifications is colored yellow instead of orange, and the inline key specifier text in the application log text is not purple. So it looks like some color incompatibility problems in general. Maybe you could peek around once this is merged and see if you can find better color values.

Yeah, the purple isn't showing through at all for me. Are you using xterm?

Also, I didn't realize it was purple, that's another constant you could make...

The color incompatibility is especially odd consider tview is based on tcell, whose readme opens with

Tcell is a Go package that provides a cell based view for text terminals, like xterm.

JoeGruffins

lgtm?

chappjc

Partial review

client/cmd/dexc/main.go

chappjc · 2020-01-13T23:45:37Z

client/cmd/dexc/main.go

+	// DRAFT NOTE: It's a little odd that the Configure function is from the ui
+	// package. The ui.Config struct is used both here and in ui. Could create  a
+	// types package used by both, but doing it this way works for now.


I only see createApp() in cmd/dexc/ui/widgets.go accessing the package-level cfg variable. All of config.go could be moved up to cmd/dexc if we make a separate ui.Config struct that has only what ui.createApp needs. This would be nice anyway since the Config struct used by go-flags has fields (and all struct field tags) that are only relevant to package main. But you're right, this does work for now.

client/cmd/dexc/ui/config_test.go

client/cmd/dexc/ui/journal_test.go

client/cmd/dexc/ui/depthchart.go

buck54321 · 2020-01-14T20:46:51Z

I must've botched a rebase somewhere. I think I've got it back now, but my history might be a little funky.

chappjc

This is really slick looking and it all seems to work right in my testing. It takes a little getting used to tabs to go between test boxes and buttons when arrows are intuitive though.

client/cmd/dexc/ui/accountsview.go

chappjc · 2020-01-15T14:27:38Z

client/cmd/dexc/ui/config.go

+		if _, ok := err.(*os.PathError); !ok {
+			fmt.Fprintln(os.Stderr, err)
+			parser.WriteHelp(os.Stderr)
+			return nil, err
+		}


Yeah, it would be As, but I'm comfortable with it the old way too.

client/cmd/dexc/ui/depthchart.go

chappjc · 2020-01-15T16:23:27Z

client/cmd/dexc/ui/depthchart.go

+		app.QueueUpdate(func() {
+			log.Errorf("interpolate error: %v", err)
+		})


heh, not too bad after all. 🤦‍♂️ I missed that app.QueueUpdate was available here.

This is a basic skeleton for a client app. It enables running an HTTP server or an RPC server. They both use the same client core, from the new core module. The default behavior is to run the servers from a simple but expandable TUI, but they can also be run without the TUI via command-line arguments or configuration file. Placeholder packages for the actual servers are in place, but don't do anything yet. A basic TUI infrastructure is built on tview, with enough code to demonstrate its use, but ultimately no functionality yet. I'm hoping this provides a good framework on which concurrent development can proceed.

buck54321 force-pushed the clientapp branch from dddc2ea to 372bf6c Compare December 10, 2019 15:04

buck54321 force-pushed the clientapp branch from 372bf6c to 02f12f3 Compare December 20, 2019 15:32

buck54321 marked this pull request as ready for review December 30, 2019 12:53

JoeGruffins reviewed Jan 8, 2020

View reviewed changes

buck54321 force-pushed the clientapp branch from eac35f9 to 47ece4c Compare January 8, 2020 14:01

JoeGruffins approved these changes Jan 8, 2020

View reviewed changes

buck54321 force-pushed the clientapp branch from e711bf8 to 4ab3e21 Compare January 11, 2020 15:03

chappjc reviewed Jan 14, 2020

View reviewed changes

buck54321 force-pushed the clientapp branch from 4ab3e21 to 1741def Compare January 14, 2020 20:12

buck54321 force-pushed the clientapp branch from 1741def to cb44260 Compare January 14, 2020 21:06

chappjc reviewed Jan 15, 2020

View reviewed changes

buck54321 force-pushed the clientapp branch from ab5e885 to ba8ce3d Compare January 15, 2020 16:06

chappjc reviewed Jan 15, 2020

View reviewed changes

chappjc approved these changes Jan 15, 2020

View reviewed changes

buck54321 added 11 commits January 15, 2020 10:40

checkpoint

5e1d532

docs

5b51f18

refactor config

909d81a

handle all keys for main menu. config fixes

245c16b

add journal buffer test and reg form fields

6df5042

checkpoint

f5e4efd

fix data race. use fixed width main menu

e76d894

more config

1025c2e

rebase cleanup

31fea47

restore lost commit

1115fc6

buck54321 added 3 commits January 15, 2020 10:40

calcRows optimizations

7570e4f

use ctx.Done instead of WaitGroup

9da16a7

touchups

9d41fe4

buck54321 force-pushed the clientapp branch from ba8ce3d to 9d41fe4 Compare January 15, 2020 16:46

chappjc merged commit 81af510 into decred:master Jan 15, 2020

buck54321 mentioned this pull request Jan 23, 2020

client: console-based UI ideas #80

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client: application skeleton #100

client: application skeleton #100

buck54321 commented Dec 10, 2019

JoeGruffins commented Dec 11, 2019

chappjc commented Dec 11, 2019

buck54321 commented Dec 11, 2019

chappjc commented Dec 11, 2019

JoeGruffins left a comment •

edited

Loading

JoeGruffins Jan 8, 2020

buck54321 Jan 8, 2020

JoeGruffins Jan 8, 2020

chappjc Jan 15, 2020

JoeGruffins Jan 8, 2020

buck54321 Jan 8, 2020

JoeGruffins Jan 8, 2020

buck54321 Jan 8, 2020

buck54321 Jan 8, 2020

JoeGruffins Jan 8, 2020

buck54321 Jan 9, 2020 •

edited

Loading

JoeGruffins Jan 9, 2020

JoeGruffins Jan 9, 2020

buck54321 Jan 11, 2020 •

edited

Loading

JoeGruffins left a comment

chappjc left a comment

chappjc Jan 13, 2020 •

edited

Loading

buck54321 commented Jan 14, 2020

chappjc left a comment

chappjc Jan 15, 2020

chappjc Jan 15, 2020

client: application skeleton #100

client: application skeleton #100

Conversation

buck54321 commented Dec 10, 2019

JoeGruffins commented Dec 11, 2019

chappjc commented Dec 11, 2019

buck54321 commented Dec 11, 2019

chappjc commented Dec 11, 2019

JoeGruffins left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 Jan 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 Jan 11, 2020 • edited Loading

Choose a reason for hiding this comment

JoeGruffins left a comment

Choose a reason for hiding this comment

chappjc left a comment

Choose a reason for hiding this comment

chappjc Jan 13, 2020 • edited Loading

Choose a reason for hiding this comment

buck54321 commented Jan 14, 2020

chappjc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins left a comment •

edited

Loading

buck54321 Jan 9, 2020 •

edited

Loading

buck54321 Jan 11, 2020 •

edited

Loading

chappjc Jan 13, 2020 •

edited

Loading