client/btc: fix racing test

decred · Feb 22, 2023 · 9a612a3 · 9a612a3
1 parent 2d99cc4
commit 9a612a3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/client/asset/btc/spv_test.go b/client/asset/btc/spv_test.go
@@ -328,7 +328,7 @@ func (c *tNeutrinoClient) GetBlockHash(blockHeight int64) (*chainhash.Hash, erro
 func (c *tNeutrinoClient) BestBlock() (*headerfs.BlockStamp, error) {
 	c.blockchainMtx.RLock()
 	if c.getBestBlockHashErr != nil {
-		c.blockchainMtx.RUnlock()
+		defer c.blockchainMtx.RUnlock() // reading c.getBestBlockHashErr below
 		return nil, c.getBestBlockHashErr
 	}
 	c.blockchainMtx.RUnlock()