Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home layout refinement #970

Merged
merged 6 commits into from
Feb 4, 2019
Merged

home layout refinement #970

merged 6 commits into from
Feb 4, 2019

Conversation

gozart1
Copy link
Member

@gozart1 gozart1 commented Jan 31, 2019

This PR explores alternative possibilities for handling homepage layout in
#961

Note this PR bumps up the boostrap grid to 24 cols, so would require updating the rest of the views if adopted.

Mainly I'd like to find ways to make the layout simple, more uniform and space efficient

screen shot 2019-01-31 at 2 25 01 am

screen shot 2019-01-31 at 2 23 24 am

@jholdstock
Copy link
Member

I think this looks really, really great.

My main sources of info tend to be dcrdata for block/tx data, and dcrstats.com for PoS/PoW info.

This kind of change would really make dcrdata a true contender for replacing dcrstats.com - something I have wanted to see for a long time :)

@chappjc
Copy link
Member

chappjc commented Jan 31, 2019

@gozart1 You can rebase just 412f311 on master now that #961 is in. Or make a new branch from the updated master and cherry pick 412f311 (whatever floats your boat).

@jholdstock
Copy link
Member

A tooltip (or similar) might be nice to explain how the exchange rate is being calculated.

I'm probably wrong, but I believe this is the first time dcrdata has shown information from a source other than the decred blockchain. It would be nice to know what the data source is, especially if it is something like fiat pricing. Fiat price can be quite a sensitive topic for some people, so it's good to be open about where the number is coming from

@gozart1
Copy link
Member Author

gozart1 commented Feb 2, 2019

Rebased.

  • updated mempool transaction label colors to use brand colors ( kept the pink though b/c there's not enough contrast within the 6 brand colors for 4 distinct labels )
  • refined layout and typography slightly to improve mobile viewing

Wide screen
screen shot 2019-02-02 at 1 57 48 am
Narrow screen
screen shot 2019-02-02 at 1 58 28 am
Mobile
screen shot 2019-02-02 at 2 29 11 am

@gozart1 gozart1 changed the title home layout alternatives (WIP) home layout refinement Feb 2, 2019
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Looks awesome.

@chappjc chappjc merged commit 62adc56 into decred:master Feb 4, 2019
@xaur
Copy link

xaur commented Feb 5, 2019

This kind of change would really make dcrdata a true contender for replacing dcrstats.com - something I have wanted to see for a long time :)

Me too. What's lacking for me to replace dcrstats is clear recent tix price chart and clear recent price chart. I open dcrstats to see if it's a good time to buy tix, and tix price chart on the main page saves time.

@chappjc chappjc added this to the 4.1 milestone Mar 18, 2019
@chappjc chappjc modified the milestones: 4.1, 4.0 Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants