work around grt rpc not handling old coinbase properly #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
reviewed
Nov 21, 2020
| @@ -5774,7 +5777,7 @@ func (pgb *ChainDB) GetExplorerTx(txid string) *exptypes.TxInfo { | |||
| valueIn, _ := dcrutil.NewAmount(vin.AmountIn) | |||
| // Do not attempt to look up prevout if it is a coinbase or stakebase | |||
| // input, which does not spend a previous output. | |||
| if !(vin.IsCoinBase() || (vin.IsStakeBase() && i == 0)) { | |||
| if !(txhelpers.IsCoinbaseVin(vin) || (vin.IsStakeBase() && i == 0)) { | |||
There was a problem hiding this comment.
Looks like you need to do something similar to catch the zeroth treasurybase input here too. e.g. for tx b35eb58a6bb092c251dc4338d0c1c9891ff7786538e432b777f1d545c2ac0958.
2020/11/21 03:50:27 http: panic serving 127.0.0.1:44776: runtime error: index out of range [0] with length 0
...
github.com/decred/dcrdata/db/dcrpg/v5.(*ChainDB).GetExplorerTx(0xc000144d00, 0xc01e7ef333, 0x40, 0xffffffffffffffff)
/home/buck/programs/dcrdata/db/dcrpg/pgblockchain.go:5837 +0x1c46
But OK with
if !(txhelpers.IsCoinbaseVin(vin) || (txhelpers.IsStakebaseVin(vin) && i == 0) || (i == 0 && standalone.IsTreasuryBase(msgTx))) {
There was a problem hiding this comment.
I had actually started to update the modules and dependencies, including blockchain/standalone in this branch: https://github.com/chappjc/dcrdata/commits/nomod
But it looks like in a lot of these checks it's sufficient to detect a null prevout https://github.com/decred/dcrd/blob/master/blockchain/standalone/tx.go#L96
|
Superseded by #1796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.