multi: drop sqlite #1480
Merged
multi: drop sqlite #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
no-sqlite
branch
3 times, most recently
from
98e13a2
to
0a0ae52
Compare
buck54321
commented
Aug 7, 2019
buck54321
commented
Aug 7, 2019
chappjc
requested changes
Aug 15, 2019
| @@ -579,7 +579,7 @@ type TicketPoolValsAndSizes struct { | |||
| StartHeight uint32 `json:"start_height"` | |||
| EndHeight uint32 `json:"end_height"` | |||
| Value []float64 `json:"value"` | |||
| Size []float64 `json:"size"` | |||
| Size []uint32 `json:"size"` | |||
There was a problem hiding this comment.
Note to self: api/types major version bump needed (to v5)
chappjc
reviewed
Aug 16, 2019
|
|
||
| func makeARRAYOfBIGINTs(ints []uint64) string { | ||
| if len(ints) == 0 { | ||
| return "'{}'::BIGINT[]" // cockroachdb: "ARRAY[]:::BIGINT[]" |
There was a problem hiding this comment.
Oh, I wonder if I was doing this string gen stuff because cockroachdb sucks with the lib/pq driver. Ah well, maybe cockroach will be more compatible someday. The right way to do this is how you got it now, with pq.Array/etc.
|
Would you also please remove |
|
All good with a fresh resync: Although I miss a report at this stage (before indexing etc.) that says height and elapsed time. |
|
Upgrade went smoothly in 12 minutes: |
chappjc
reviewed
Aug 16, 2019
db/dcrpg/sync.go
Outdated
| panic("invalid starting height") | ||
| } | ||
|
|
||
| log.Info("Current best block (chain server): ", lastBlock) |
There was a problem hiding this comment.
This one is not (chain server), but the postgresql db height, whatever we want to call that.
But also logging nodeHeight around here would be good too.
Upgrade the pgsql database, adding a stats table and a winners column to the blocks table. This is a lengthy upgrade that requires pulling MsgBlocks for the entire blockchain and evolving the ticket pool.
chappjc
approved these changes
Aug 19, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Database Upgrade* - Create a backup before running this branch
Removes SQLite database. Everything is moved to
ChainDB.In fact, nearly everything that needed to be moved was put in pgblockchain.go for now.I'll probably do some more organizing before removing from draft status, though.For full testing, you'll need dcrlabs/bug-free-happiness#6
It has passed the following tests.
go testwith all combinations of-tagsin dcrpgapiload -a rotationThe database upgrade itself is fairly long. Took ~30 minutes on my SSD. This is because the entire blockchain must be requested again and the ticket pool evolved appropriately to populate the stats table.
I think that @chappjc has expressed some interest in combining
ChainDBandChainDBRPC.I didn't do that yet, but unless there a reason not to, I may grab that here as well.doneIn addition to some further organizing the dcrpg package, I imagine there is some optimization to be done in the main loop now that there are fewer data sources to sync.