explorer: add semi-bold font #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a semi-bold font and uses it for table headers throughout. Also applied to address on address page and txid on tx page.
|
That's much easier on the eyes. Yeah, minifying font SVGs is likely to mess it up. I wanna have a look though anyway to see if there's anything obvious bloat the files. |
|
Well, there doesn't seem to be much to "clean up" in source-sans-pro-semibold.svg, but it compresses well.
|
chappjc
reviewed
Jun 28, 2019
go.sum
Outdated
| @@ -131,6 +131,7 @@ github.com/decred/dcrd/wire v1.1.0 h1:G+3CugtxNbToUN8RKWqm74yLfzJJ2BKMOr2RgWc4Ty | |||
| github.com/decred/dcrd/wire v1.1.0/go.mod h1:/JKOsLInOJu6InN+/zH5AyCq3YDIOW/EqcffvU8fJHM= | |||
| github.com/decred/dcrd/wire v1.2.0 h1:HqJVB7vcklIguzFWgRXw/WYCQ9cD3bUC5TKj53i1Hng= | |||
| github.com/decred/dcrd/wire v1.2.0/go.mod h1:/JKOsLInOJu6InN+/zH5AyCq3YDIOW/EqcffvU8fJHM= | |||
| github.com/decred/dcrdata v2.1.3+incompatible h1:DLzrqgOOgHwrUSbuOVDAUzfQePhCGl9UsjEgZI1D0Kg= | |||
There was a problem hiding this comment.
Could you revert this line pls?
chappjc
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a semi-bold font and uses it for table headers throughout. Also applied to address on address page and txid on tx page.
A medium-weight font was called for in a number of places in #451, but I could never get it to work with the fonts we had, and I'm admittedly not very knowledgeable on fonts.
@chappjc You're usually on top of minifying SVGs, but I wasn't sure about fonts since they contain possibly important metadata.