netsync: Contiguous hashes for initial state reqs. #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstaudt2
approved these changes
Nov 20, 2021
dnldd
approved these changes
Nov 24, 2021
This modifies the internal messaging for initial state requests to use slices of contiguous block hashes instead of slices of pointers. Contiguous slices produce much less heap objects that the GC needs to scan and are better for cache locality.
davecgh
force-pushed
the
netsync_initial_state_contiguous_hashes
branch
from
a5e47e8
to
4627832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the internal messaging for initial state requests to use slices of contiguous block hashes instead of slices of pointers. Contiguous slices produce much less heap objects that the GC needs to scan and are better for cache locality.