stdscript: Add consolidated stake extracts. #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstaudt2
approved these changes
Nov 19, 2021
chappjc
approved these changes
Nov 19, 2021
This adds support for directly extracting the public key hash from standard version 0 stake-tagged pay-to-pubkey-hash scripts along with full test coverage. While all of this data can be extracted from each individual type, it can be more convenient for callers who treat all public key hashes as the same entity which is the case for many applications.
BenchmarkExtractStakePubKeyHashV0 --------------------------------- v0_complex_non_standard-16 229676676 5.139 ns/op v0_stake_submission_p2pkh-ecdsa-secp256k1-16 335241789 3.531 ns/op v0_stake_gen_p2pkh-ecdsa-secp256k1-16 268142942 4.517 ns/op v0_stake_revoke_p2pkh-ecdsa-secp256k1-16 244045095 4.908 ns/op v0_stake_change_p2pkh-ecdsa-secp256k1-16 220275314 5.441 ns/op v0_treasury_generation_p2pkh-ecdsa-secp256k1-16 197104339 6.086 ns/op
This adds support for directly extracting the script hash from standard version 0 stake-tagged pay-to-script-hash scripts along with full test coverage. While all of this data can be extracted from each individual type, it can be more convenient for callers who treat all script hashes as the same entity which is the case for many applications.
BenchmarkExtractStakeScriptHashV0 --------------------------------- v0_complex_non_standard 226793582 5.253 ns/op v0_stake_submission_p2sh 372232682 3.233 ns/op v0_stake_gen_p2sh 305602378 3.979 ns/op v0_stake_revoke_p2sh 201691552 5.064 ns/op v0_stake_change_p2sh 209401243 5.687 ns/op v0_treasury_generation_p2sh 221794405 5.419 ns/op
davecgh
force-pushed
the
stdscript_consolidated_stake_extracts
branch
from
cfdada9
to
b1b9a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for extracting the public key and script hashes from version 0 scripts that are any of of the standard types usable in the staking system along with associated tests and benchmarks.
Namely, it adds
ExtractStakePubKeyHashV0ExtractStakeScriptHashV0While all of the data can be extracted from each individual type, it can be more convenient for callers who treat all types of script hashes and/or public key hashes as the same entity which is the case for many applications.