blockchain: Fix ticket db disconnect revocations. #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue in the ticket database when disconnecting a block that contains an automatic revocation. When the automatic ticket revocations agenda is enabled, a ticket can become missed and revoked in the same block. When connecting that block to the ticket database, this is recorded as two separate entries in the undo data (the first moving it to missed, and the second moving it to revoked). Therefore, when disconnecting the block, the undo data needs to be applied in reverse order.
davecgh
approved these changes
Oct 25, 2021
dnldd
approved these changes
Oct 25, 2021
JoeGruffins
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue in the ticket database when disconnecting a block that contains an automatic revocation.
When the automatic ticket revocations agenda is enabled, a ticket can become missed and revoked in the same block. When connecting that block to the ticket database, this is recorded as two separate entries in the undo data (the first moving it to missed, and the second moving it to revoked). Therefore, when disconnecting the block, the undo data needs to be applied in reverse order.