rpcserver: Impose additional read limits. #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imposes additional per-connection read limits on the RPC server to help further harden it against potential abuse in non-standard configurations on poorly-configured networks. In practice, these changes will not have any noticeable effect for the vast majority of nodes since the RPC server is not publicly accessible by default and requires authentication. Nevertheless, it can still be useful to apply additional read limits for scenarios such as authenticated fuzz testing and poorly-configured networks that have disabled all other security measures. The following are the updated per-connection limits: - 0 B / 8 MiB for pre and post auth HTTP connections - 4 KiB / 16 MiB for pre and post auth websocket connections
dnldd
approved these changes
Jul 1, 2021
jrick
approved these changes
Jul 1, 2021
JoeGruffins
approved these changes
Jul 2, 2021
rstaudt2
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imposes additional per-connection read limits on the RPC server to help further harden it against potential abuse in non-standard configurations on poorly-configured networks.
In practice, these changes will not have any noticeable effect for the vast majority of nodes since the RPC server is not publicly accessible by default and requires authentication.
Nevertheless, it can still be useful to apply additional read limits for scenarios such as authenticated fuzz testing and poorly-configured networks that have disabled all other security measures.
The following are the updated per-connection limits: