secp256k1: Implement direct signature verification. #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
changed the title
matheusd
reviewed
Feb 3, 2020
davecgh
force-pushed
the
secp2561k_implement_direct_sig_verify
branch
from
dccfabd
to
6844861
Compare
matheusd
approved these changes
Feb 4, 2020
dajohi
approved these changes
Feb 5, 2020
dnldd
reviewed
Feb 10, 2020
This implements signature verification directly instead of calling the version in the standard library in order to ultimately be able to break the reliance on big ints it requires and thus allow for optimization specifically for the sec256k1 curve. It currently is only marginally faster since it still relies on big ints. However, there is already a 10% reduction in allocations which reduces pressure on the GC during IBD when there are a ton of signature verifications happening. benchmark old ns/op new ns/op delta ----------------------------------------------------- BenchmarkSigVerify 224238 219603 -2.07% benchmark old allocs new allocs delta ----------------------------------------------------- BenchmarkSigVerify 64 57 -10.94% benchmark old bytes new bytes delta ----------------------------------------------------- BenchmarkSigVerify 3138 2818 -10.20%
davecgh
force-pushed
the
secp2561k_implement_direct_sig_verify
branch
from
6844861
to
a891117
Compare
dnldd
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #2057.
This implements signature verification directly instead of calling the version in the standard library in order to ultimately be able to break the reliance on big ints it requires and thus allow for optimization specifically for the sec256k1 curve.
It currently is only marginally faster since it still relies on big ints. However, there is already a 10% reduction in allocations which reduces pressure on the GC during IBD when there are a ton of signature verifications happening.