bech32: Add base256 conversion convenience funcs. #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
reviewed
Dec 27, 2019
|
@matheusd There is an "empty hrp" test. Are you referring to something else? |
|
Sorry, should have been "no separator present" test (i.e., not a single "1" character in the string). |
|
Added no separator test. |
matheusd
approved these changes
Dec 27, 2019
dajohi
approved these changes
Dec 27, 2019
Since bech32 itself works with data encoded with 5 bits per byte (aka base32) padded out to the nearest byte boundary, the existing functions for Encode and Decode accept and return data encoded that way. However, the most common way to use bech32 is to encode data that is already encoded with 8 bits per byte (aka base256) without padding which means it is up to the caller to use the ConvertBits function properly to convert between the two encodings. Consequently, this introduces two convenience functions for working directly with base256-encoded data named EncodeFromBase256 and DecodeToBase256 along with a full set of tests to ensure they work expected.
davecgh
force-pushed
the
bech32_add_base256_convenience_funcs
branch
from
da14459
to
3cfb088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #2024.
Since
bech32itself works with data encoded with 5 bits per byte (aka base32) padded out to the nearest byte boundary, the existing functions forEncodeandDecodeaccept and return data encoded that way.However, the most common way to use
bech32is to encode data that is already encoded with 8 bits per byte (aka base256) without padding which means it is up to the caller to use theConvertBitsfunction properly to convert between the two encodings.Consequently, this introduces two convenience functions for working directly with base256-encoded data named
EncodeFromBase256andDecodeToBase256along with a full set of tests to ensure they work as expected.