multi: Add HTTP seeder support. #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jan 5, 2020
davecgh
requested changes
Jan 10, 2020
davecgh
requested changes
Jan 10, 2020
There was a problem hiding this comment.
The third commit needs to be amended to conform to the code contribution guidelines and I would also suggest updating the commit the deprecates nodnsseed to also deprecate the chaincfg.Params.DNSSeeds field since it will need to be removed in the next major version bump of chaincfg.
Seeder identifies the hostname as a seeder.
connmgr: deprecate SeedFromDNS config: deprecate nodnsseed; add noseeders
davecgh
approved these changes
Jan 12, 2020
|
I added a debug statement to ensure the returned values match the query string as expected and verified that it works as expected over Tor as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires decred/dcrseeder#25