multi: Introduce initial sync min known chain work. #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
multi_introduce_min_known_chain_work
branch
from
d82c0fa
to
71b5188
Compare
jrick
approved these changes
Nov 19, 2019
dnldd
approved these changes
Nov 19, 2019
This adds a new parameter to the chain parameters to allow a minimum total known cumulative amount of chain work to be specified as of a given point in time and updates the check which determines if the blockchain believes it is current to make use of the value instead of the height of the final checkpoint. In other words, the chain is not considered synced if the best chain does not yet have the amount of work specified. This approach is preferred because it easier to maintain, does not rely on trusted known good checkpoints, is valid regardless of the order that blocks are received and processed, and, in general, is a more objective value that can't be invalidated by a chain reorganization. It also adds initial values for the main and test networks as follows: mainnet: 0x0000000000000000000000000000000000000000000ae01920a7ee4b769cc620 testnet: 0x0000000000000000000000000000000000000000000000005df2701ec6263182
davecgh
force-pushed
the
multi_introduce_min_known_chain_work
branch
from
71b5188
to
60b07a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to the chain parameters to allow a minimum total known cumulative amount of chain work to be specified as of a given point in time and updates the check which determines if the blockchain believes it is current to make use of the value instead of the height of the final checkpoint. In other words, the chain is not considered synced if the best chain does not yet have the amount of work specified.
This approach is preferred because it easier to maintain, does not rely on trusted known good checkpoints, is valid regardless of the order that blocks are received and processed, and, in general, is a more objective value that can't be invalidated by a chain reorganization.
It also adds initial values for the main and test networks as follows: