Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: Use harness in force head reorg tests. #1584

Merged

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jan 27, 2019

This requires #1583.

This refactors the force head reorganization tests in blockchain to use the recently introduced chaingen harness.

@davecgh davecgh added this to the 1.5.0 milestone Jan 27, 2019
@davecgh davecgh force-pushed the blockchain_test_chaingen_harness_forceheadreorg branch from d2a34c0 to 4cfce67 Compare January 27, 2019 15:33
Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test harness really improves readability on the individual tests. Nicely done!

This refactors the force head reorganization tests in blockchain to use
the recently introduced chaingen harness.
@davecgh davecgh force-pushed the blockchain_test_chaingen_harness_forceheadreorg branch from 4cfce67 to 10f23b0 Compare January 29, 2019 19:27
@davecgh davecgh merged commit 10f23b0 into decred:master Jan 29, 2019
@davecgh davecgh deleted the blockchain_test_chaingen_harness_forceheadreorg branch January 29, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants