blockchain: Remove unused CheckWorklessBlockSanity. #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the CheckWorklessBlockSanity function since nothing uses it anymore. It was used for testing templates and unit tests in the past, but the former is now handled by CheckConnectBlockTemplate and the latter is handled by the full block tests. It should be noted that this is a breaking change to the API and thus will need a major version bump of the blockchain module to be published before the next release.
davecgh
force-pushed
the
blockchain_remove_checkworklessblocksanity
branch
from
a4b8824
to
274815a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
CheckWorklessBlockSanityfunction since nothing uses it anymore. It was used for testing templates and unit tests in the past, but the former is now handled byCheckConnectBlockTemplateand the latter is handled by the full block tests.It should be noted that this is a breaking change to the API and thus will need a major version bump of the blockchain module to be published before the next release.