docs: Add github pull request template. #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
github_pr_template
branch
2 times, most recently
from
31665f3
to
ea3ae6f
Compare
jrick
reviewed
Oct 1, 2018
.github/pull_request_template.md
Outdated
| * [ ] Any new logging statements use an appropriate subsystem and logging level | ||
| * [ ] Code has been formatted with go fmt | ||
| * [ ] Running go test does not fail any tests | ||
| * [ ] Running go vet does not report any issues |
There was a problem hiding this comment.
I think this is unnecessary since go test in Go 1.11 will fail if vet fails.
There was a problem hiding this comment.
Good point. That was changed. I updated it to remove this line and instead say:
* [ ] Running go test does not fail any tests or report any vet issues
This adds a pull request template which provides a checklist and links to the code contribution guidelines to help contributors ensure they are adhering to project standards.
davecgh
force-pushed
the
github_pr_template
branch
from
ea3ae6f
to
979d21f
Compare
jrick
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pull request template which provides a checklist and links to the code contribution guidelines to help contributors ensure they are adhering to project standards.