Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: Store interrupt channel with state. #1467

Closed

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Sep 21, 2018

This modifies the Blockchain struct to keep a reference to the interrupt channel (if any) provided by the caller. While currently it is not used outside of the initialization path, having it available in the state will be useful for other use cases such as being able to decouple reorgs from the download state and allowing interrupts of long reorgs.

@davecgh davecgh added this to the 1.4.0 milestone Sep 21, 2018
Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@davecgh davecgh closed this Sep 26, 2018
@davecgh davecgh force-pushed the blockchain_store_interrupt_chan branch from b97111b to ea8aa1e Compare September 26, 2018 12:12
@davecgh davecgh deleted the blockchain_store_interrupt_chan branch September 26, 2018 12:12
@davecgh
Copy link
Member Author

davecgh commented Sep 26, 2018

This was merged. Github improperly marked it as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants