Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: add notifywork websocket rpc. #1410

Merged
merged 1 commit into from
Oct 13, 2019
Merged

multi: add notifywork websocket rpc. #1410

merged 1 commit into from
Oct 13, 2019

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Aug 21, 2018 •
edited
Loading

resolves #1032.

@davecgh davecgh changed the title multi: add notifywork websocket rpc. WIP: multi: add notifywork websocket rpc. Aug 22, 2018
@davecgh davecgh added this to the 1.4.0 milestone Aug 23, 2018
@dnldd dnldd changed the title WIP: multi: add notifywork websocket rpc. multi: add notifywork websocket rpc. Sep 7, 2018
@dnldd
Copy link
Member Author

dnldd commented Sep 7, 2018

Tested on testnet.

2018/09/07 19:13:13 Client shutdown in 1 hour...
2018/09/07 19:13:21 New Work (header: 06000000658ad5dba7c30a81d6e7df5009ba8ca19903d667e65a9e36e024c907000000004e8eef390c4521beae41c4f35840c9e6146c1f1a7cebfbc084f9df9b1ffe1776406ce5f7ef861cdc1d3b42b4edb90818cf3b9da1f81c2ebf143f76d8184cce600100
f26fe7202456050014008e1300003326081cc14dff3400000000e2530000ea200000d1cd925b000000000000000000000000000000000000000000000000000000000000000000000000060000008000000100000000000005a0 , target: 0000000000000000000000000000000000000000000000000033260800000000)
2018/09/07 19:13:21 New Work (header: 06000000658ad5dba7c30a81d6e7df5009ba8ca19903d667e65a9e36e024c90700000000e98e61777d43562623316ee70858dd31d2a2bba0366760e17dc120bfdf87dec0406ce5f7ef861cdc1d3b42b4edb90818cf3b9da1f81c2ebf143f76d8184cce600100
f26fe7202456050014008e1300003326081cc14dff3400000000e2530000ea200000d1cd925b000000000000000000000000000000000000000000000000000000000000000000000000060000008000000100000000000005a0 , target: 0000000000000000000000000000000000000000000000000033260800000000)
2018/09/07 19:13:21 New Work (header: 06000000caaddbc12ab86926e6a1b1ea6ba04641e1828385bd1b93b0bcabc701000000002d42fb67badd11df849bfcdc04abc0a6fff88f859505f295081249ce3e62a713625a10a3f987ac7ce7588f1df01a0edb6e89e7c3dd5da795eb3220897451f2ca0100
606b4ff59672030001008d1300003326081cc14dff3400000000e353000037080000d1cd925b000000000000000000000000000000000000000000000000000000000000000000000000060000008000000100000000000005a0 , target: 0000000000000000000000000000000000000000000000000033260800000000)
2018/09/07 19:13:21 New Work (header: 06000000caaddbc12ab86926e6a1b1ea6ba04641e1828385bd1b93b0bcabc701000000008011d7b4432e80da17edbcbdfd8271067658b7393855ee6a6b6d65339cc797beedd841426e0b316c69d2c05aa5cd1cc531695cb30f79bbf4cd4bb9dc77ece7210100
606b4ff59672040001008d1300003326081cc14dff3400000000e353000090090000d1cd925b000000000000000000000000000000000000000000000000000000000000000000000000060000008000000100000000000005a0 , target: 0000000000000000000000000000000000000000000000000033260800000000)
...

@dnldd dnldd force-pushed the notifywork branch 5 times, most recently from 06c8a62 to 71ca39f Compare November 19, 2018 09:28
@davecgh davecgh modified the milestones: 1.4.0, 1.5.0 Dec 11, 2018
@dnldd dnldd force-pushed the notifywork branch 2 times, most recently from c8c2fcd to fad46ce Compare January 19, 2019 11:38
@dajohi
Copy link
Member

dajohi commented Feb 10, 2019

@dnldd please rebase.

davecgh
davecgh requested changes Oct 11, 2019
View reviewed changes
rpcclient/infrastructure.go Outdated Show resolved Hide resolved
rpcclient/notify.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcwebsocket.go Outdated Show resolved Hide resolved
davecgh
davecgh approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and I've tested that works properly, thus I'm approving it. However, it needs #1922 to go in first in order to work due to a fix that PR contains.

@davecgh davecgh merged commit cc3374f into decred:master Oct 13, 2019
@davecgh davecgh mentioned this pull request Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

GetWork notifications over Websocket
3 participants
@dnldd @dajohi @davecgh