Move revalidation of unmixed data to blame assignment #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the unmixed portion of a mix becomes invalid between the time the KEs are broadcasted and after the mix is confirmed by all peers, e.g. due to a double spend, publishing the mix would fail without any possible blame assignment. This leads to a potential DoS. Moving the revalidation of the original unmixed data submitted in the pair request from the KEs broadcast to the blame assignment prevents this issue. This DoS has not been exploited to our knowledge. While here, perform validation concurrently to reduce issues caused by dcrd RPC latency, which could lead to revalidation taking longer than a client timeout duration.
davecgh
approved these changes
Nov 22, 2021
dajohi
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the unmixed portion of a mix becomes invalid between the time the
KEs are broadcasted and after the mix is confirmed by all peers, e.g.
due to a double spend, publishing the mix would fail without any
possible blame assignment. This leads to a potential DoS. Moving the
revalidation of the original unmixed data submitted in the pair
request from the KEs broadcast to the blame assignment prevents this
issue. This DoS has not been exploited to our knowledge.
While here, perform validation concurrently to reduce issues caused by
dcrd RPC latency, which could lead to revalidation taking longer than
a client timeout duration.