Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Sidebar hovering click #215

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Expand Sidebar hovering click #215

merged 2 commits into from
Dec 5, 2023

Conversation

ItamarRocha
Copy link
Contributor

@ItamarRocha ItamarRocha commented Dec 5, 2023 •
edited
Loading

This PR contains the following alterations:

  • Update SideBar subTopics to be clickable on the whole block.

Previously, only clicking the text would generate the link redirection, which could be confusing given the hovering behavior.

Before After
loomvideo loomvideo

@ItamarRocha ItamarRocha requested a review from lucis December 5, 2023 14:17
@ItamarRocha ItamarRocha self-assigned this Dec 5, 2023
lucis
lucis approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@lucis lucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!

@ItamarRocha ItamarRocha merged commit a15171c into main Dec 5, 2023
4 checks passed
@ItamarRocha ItamarRocha added the bug Something isn't working label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucis lucis lucis approved these changes

Assignees

@ItamarRocha ItamarRocha

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItamarRocha @lucis